feat: replace browser reload with in-place reset for VS "New" diagram#16
Open
DisciplinedSoftware wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DisciplinedSoftware
force-pushed
the
feat/vs-new-without-reload
branch
from
21d466f to
6068d6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The VS Code and Visual Studio plugins previously handled the "New diagram" action differently:
mind.refresh(defaultData)+mind.clearHistory()on the existingmindinstance.MindMapBrowser.Reload(), which destroyed and recreated the entire browser context, resetting history as a side effect.This PR aligns the Visual Studio plugin with the VS Code approach so both plugins use the same mechanism: an in-place
mind.refresh()+mind.clearHistory().Changes
CodeMindMapHtml.csAdded a
window.resetMindMap()JS function that:initMindMap()mind.refresh()(same workaround already used inimportData)mind.refresh(defaultData)+mind.clearHistory()MindMapToolWindowControl.xaml.csChanged
NewCodeMindMapClickto callawait MindMapBrowser.ExecuteScriptAsync("resetMindMap()")instead ofReloadMindMapBrowser(). The C# side (package data management) is unchanged.Result
Both plugins now reset the mind map in-place without a full browser reload. History is cleared explicitly via
clearHistory()in both cases.